Skip to content

MRG Remove the use of assert_warns and assert_warns_message from the tests #20417

Merged
ogrisel merged 7 commits intoscikit-learn:mainfrom
Gleekzone:metrics-remove-assert-warns
Jun 28, 2021
Merged

MRG Remove the use of assert_warns and assert_warns_message from the tests #20417
ogrisel merged 7 commits intoscikit-learn:mainfrom
Gleekzone:metrics-remove-assert-warns

Conversation

@Gleekzone
Copy link
Copy Markdown
Contributor

@Gleekzone Gleekzone commented Jun 28, 2021

Reference Issues/PRs

fixes #19414

What does this implement/fix? Explain your changes.

Remove the use of assert_warns and assert_warns_message in the files:

  • sklearn/metrics/tests/test_classification.py
  • sklearn/metrics/tests/test_ranking.py

Any other comments?

#DataUmbrella sprint
This PR was developed by @sofide and myself.
cc: @amueller @g-walsh

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@ogrisel ogrisel merged commit daae053 into scikit-learn:main Jun 28, 2021
@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Jun 28, 2021

Merged! Thanks @Gleekzone and @sofidenner!

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…tests (scikit-learn#20417)

Co-authored-by: Sofía Denner <sofia.denner@mercadolibre.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the use of assert_warns and assert_warns_message from the tests

3 participants