FIX Uses code literals in deprecated to prevent linking#20410
Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom Jun 28, 2021
Merged
FIX Uses code literals in deprecated to prevent linking#20410glemaitre merged 5 commits intoscikit-learn:mainfrom
glemaitre merged 5 commits intoscikit-learn:mainfrom
Conversation
This was referenced Jun 28, 2021
ogrisel
approved these changes
Jun 28, 2021
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM, assuming CI is green after the commit I just pushed.
Member
|
LGTM. Thanks @thomasjpfan |
This was referenced Jun 28, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…#20410) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #20385
What does this implement/fix? Explain your changes.
Now that docstrings for properties are exposed, sphinx considers the underscore (
_) a link. This PR makes sure all the deprecated messages refer to attributes as literals.