DOC Ensures that AdaBoostRegressor passes numpydoc validation#20400
Merged
glemaitre merged 7 commits intoscikit-learn:mainfrom Jun 28, 2021
Merged
DOC Ensures that AdaBoostRegressor passes numpydoc validation#20400glemaitre merged 7 commits intoscikit-learn:mainfrom
glemaitre merged 7 commits intoscikit-learn:mainfrom
Conversation
It's float so should be 1.0
rth
reviewed
Jun 27, 2021
Member
rth
left a comment
There was a problem hiding this comment.
Thanks @gitdoluquita . Two minor comments otherwise LGTM.
…nto 20308/AdaBoostRegressor
In AdaBoostRegressor docstring
Contributor
Author
|
Thank you so much for the feedback @rth . |
glemaitre
reviewed
Jun 28, 2021
Member
|
I merge my small suggestion at the same time than solving the conflicts. Let's wait for the CIs to complete |
Member
|
Thanks @gitdoluquita |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…-learn#20400) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#DataUmbrella sprint
Reference Issues/PRs
Adresses #20308
cc.: @lacouth pair programming partner
Removing AdaBoostRegressor from DOCSTRING_IGNORE_LIST
Fixing numpydoc errors in AdaBoostRegressor class, fit and score methods.