Skip to content

DOC Ensures BayesianGaussianMixture docstring passes numpydoc validation#20384

Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom
nico-stefani:fix_bayesian_gaussian_mixture_numpydoc_validation
Jun 28, 2021
Merged

DOC Ensures BayesianGaussianMixture docstring passes numpydoc validation#20384
glemaitre merged 3 commits intoscikit-learn:mainfrom
nico-stefani:fix_bayesian_gaussian_mixture_numpydoc_validation

Conversation

@nico-stefani
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Addresses #20308
What does this implement/fix? Explain your changes.

Fixes numpydoc errors on BayesianGaussianMixture functions

#DataUmbrella sprint
cc. @asnramos

@glemaitre glemaitre changed the title Ensure numpydoc validation on BayesianGaussianMixture DOC Ensures BayesianGaussianMixture docstring passes numpydoc validation Jun 26, 2021
@nico-stefani
Copy link
Copy Markdown
Contributor Author

@glemaitre i made the changes by myself because i don't understand the suggestion flow porposed. 🤷

@glemaitre
Copy link
Copy Markdown
Member

i made the changes by myself because i don't understand the suggestion flow proposed.

It is fine as well. Normally, you can go in the Files tab and add all suggestion in a batch and then commit the batch.

@glemaitre glemaitre merged commit b3112e0 into scikit-learn:main Jun 28, 2021
@glemaitre
Copy link
Copy Markdown
Member

I just made a small change regarding the self type otherwise it looks good. Merging.

Thanks @Nicolas471

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…ion (scikit-learn#20384)

Co-authored-by: Nico Stefani <nicolas.stefani@mercadolibre.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants