DOC Ensures that LinearRegression passes numpydoc validation#20369
Merged
glemaitre merged 4 commits intoscikit-learn:mainfrom Jun 28, 2021
Merged
DOC Ensures that LinearRegression passes numpydoc validation#20369glemaitre merged 4 commits intoscikit-learn:mainfrom
glemaitre merged 4 commits intoscikit-learn:mainfrom
Conversation
Contributor
Author
|
@glemaitre We are getting this error "Linux pylatest_pip_openblas_pandas failed" no idea what it means but seems unrelated to the DOC change. |
Member
|
So the test is no passing, you need to reformat the docstring. You need to reformat:
|
Member
|
The class is declared in the file |
Contributor
Author
|
@glemaitre thanks a lot! We just realized numpydoc was not properly installed so tests were being skipped... we will fix it and re-submit. |
Member
|
You can make the changes on your local branch, commit, and push your branch. Be aware that you don't have to open a new PR. Pushing the current PR will be synchronized in GitHub automatically. |
glemaitre
reviewed
Jun 28, 2021
Member
|
Since this is a little change, I merged my suggestion and I will merge the PR now. Thanks @gloriamacia |
Contributor
Author
|
#DataUmbrella |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…learn#20369) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308 for LinearRegression with my pair programming partner @caherrera-meli
What does this implement/fix? Explain your changes.
Added periods to docstring summaries and reorganized the classes docstring to follow the suggested order.
Any other comments?
#DataUmbrella sprint