Skip to content

TST Changes assert_raises to raises in sklearn/utils/test_estimator_checks.py#20138

Merged
ogrisel merged 14 commits intoscikit-learn:mainfrom
azihna:fix_estimator_checks
May 27, 2021
Merged

TST Changes assert_raises to raises in sklearn/utils/test_estimator_checks.py#20138
ogrisel merged 14 commits intoscikit-learn:mainfrom
azihna:fix_estimator_checks

Conversation

@azihna
Copy link
Copy Markdown
Contributor

@azihna azihna commented May 26, 2021

Reference Issues/PRs
References #14216,

What does this implement/fix? Explain your changes.
Changed the assert_raises, assert_raise_message, assert_warns to raises in the sklearn/utils/tests/test_estimator_checks.py

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @azihna !

LGTM

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks @azihna!

@ogrisel ogrisel merged commit 3c72fe5 into scikit-learn:main May 27, 2021
thomasjpfan pushed a commit to bsun94/scikit-learn that referenced this pull request Jun 5, 2021
…hecks.py (scikit-learn#20138)



Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants