Skip to content

Allowing sparse inputs for prediction in AffinityPropagation#20117

Merged
jeremiedbb merged 6 commits intoscikit-learn:mainfrom
venkyyuvy:affinity_propa_sparse_input
May 27, 2021
Merged

Allowing sparse inputs for prediction in AffinityPropagation#20117
jeremiedbb merged 6 commits intoscikit-learn:mainfrom
venkyyuvy:affinity_propa_sparse_input

Conversation

@venkyyuvy
Copy link
Copy Markdown
Contributor

@venkyyuvy venkyyuvy commented May 20, 2021

Reference Issues/PRs

Fixes #20049

What does this implement/fix? Explain your changes.

Accepts sparse data inputs for affinitiy propagation model.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @venkyyuvy ! Just a few minor comments

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Let me just rephrase the changelog a bit to make it more precise.

@jeremiedbb jeremiedbb merged commit aa86c83 into scikit-learn:main May 27, 2021
@jeremiedbb
Copy link
Copy Markdown
Member

thanks @venkyyuvy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AffinityPropagation predict does not accept sparse X

4 participants