DOC Documents n_features_in_ in cross_decomposition#19351
Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom Feb 8, 2021
Merged
DOC Documents n_features_in_ in cross_decomposition#19351glemaitre merged 1 commit intoscikit-learn:mainfrom
glemaitre merged 1 commit intoscikit-learn:mainfrom
Conversation
47 tasks
Member
|
Maybe I merged a bit fast. Do we intend to document in the same time that we add the new attribute or you wanted to have a PR with the documentation separated? |
Member
|
What happened to the 2 reviewer requirement? But I help you out 😏 |
lorentzenchr
reviewed
Feb 8, 2021
Member
lorentzenchr
left a comment
There was a problem hiding this comment.
LGTM, even if it's late.
Member
|
I added a docsting task list to #19333. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #19333
What does this implement/fix? Explain your changes.
This PR allows for us to incrementally add
n_features_in_to the docstrings.CC @lorentzenchr