check_psd_eigenvalues : fixed issue with small_pos_ratio on mac os x with python >= 3.7#18270
Merged
glemaitre merged 1 commit intoscikit-learn:masterfrom Aug 27, 2020
Merged
Conversation
…scussed in scikit-learn#18149. Updated docstring accordingly.
Member
|
It looks good. I am really thinking that we should better handle these issues in tests with a global strategy. |
Member
|
Happy to see that this solution works and the wheel builder is "building" again 😄 (see https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=21578&view=results). Thank you @smarie for the PR and @glemaitre for the review! |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…ue to floating point precision issue (scikit-learn#18270) Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue with small_pos_ratio on mac os x with python >= 3.7 by slightly raising threshold as discussed in #18149.
Updated docstring accordingly.