CI Disable 32bit pytest xdist#18161
Merged
rth merged 1 commit intoscikit-learn:masterfrom Aug 14, 2020
Merged
Conversation
Member
|
Thanks Thomas! It's not an issue with 32 bit though as other jobs are also failing but likely rather due to the pytest-xdist 2.0.0 release today. Pinning to <2.0.0 should fix it I think for now. |
Member
|
To be more specific the issues seems to be in a bad interaction between pytest-cov and pytest-xdist that should have been fixed in pytest-dev/pytest-cov#191. Maybe we are using a very outdated pytest-cov somehow? |
Member
|
Aww I see #18160. It would have really been useful to have that link for context here :) LGTM, let's merge it. |
Member
Author
|
Ah sorry, I'll be thoughtful with linking other issues. |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug with pytest-xdist with the 32bit instance on master.