Skip to content

DOC Clarify triaging role. Remove usage question template.#18142

Merged
jnothman merged 7 commits intoscikit-learn:masterfrom
cmarmo:triaging
Aug 13, 2020
Merged

DOC Clarify triaging role. Remove usage question template.#18142
jnothman merged 7 commits intoscikit-learn:masterfrom
cmarmo:triaging

Conversation

@cmarmo
Copy link
Copy Markdown
Contributor

@cmarmo cmarmo commented Aug 11, 2020 •
edited
Loading

Reference Issues/PRs

Follow #17907

What does this implement/fix? Explain your changes.

The permissions of the triaging role in github are clarified, some triaging activities are adapted to the permissions of the triaging team.
As a Request For Comment I have removed the usage question issue template.
Two reasons for that:

  • an empty issue (other) is available anyway and some usage questions will slip in by this channel
  • thanks to DOC on issue triaging process #17907, links to stackoverflow, gitter and the mailing list are provided for usage questions, the user is invited to use those channels: adding a template for that seems inconsistent to me.

Let me know your opinion on that.

@cmarmo cmarmo changed the title DOC Clarify triaging role. Remove usage question template. [WIP] DOC Clarify triaging role. Remove usage question template. Aug 12, 2020
@cmarmo cmarmo changed the title [WIP] DOC Clarify triaging role. Remove usage question template. [MRG] DOC Clarify triaging role. Remove usage question template. Aug 12, 2020
@cmarmo
Copy link
Copy Markdown
Contributor Author

cmarmo commented Aug 12, 2020

ping @GaelVaroquaux and @thomasjpfan . Thanks!

NicolasHug
NicolasHug approved these changes Aug 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmarmo, LGTM

I agree that removing the usage_question template makes sense. Should we also move the "Other" template at the bottom of the list? Right now it's at the top which is slightly weird.

It's bit sad the triage team cannot edit comments :/
Do you know of any initiative from github in that direction?

cmarmo and others added 3 commits August 12, 2020 16:37
@cmarmo
Copy link
Copy Markdown
Contributor Author

cmarmo commented Aug 12, 2020

Should we also move the "Other" template at the bottom of the list? Right now it's at the top which is slightly weird.

I think this is an issue with naming: it seems to me that templates are displayed in alphabetical order. So I have renamed 'blank_template' in 'other_template'... I don't know how to test this... I don't think I can open an issue on a specific branch...

@NicolasHug
Copy link
Copy Markdown
Member

NicolasHug commented Aug 12, 2020

I don't know how to test this

I'm not sure we can lol
Renaming should be good, worst case scenario it won't change a thing. Thanks @cmarmo

glemaitre
glemaitre approved these changes Aug 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 as well. I am not going to merge now since I think the PR would require attention of more core-dev before to get in.

Thanks @cmarmo

@jnothman jnothman changed the title [MRG] DOC Clarify triaging role. Remove usage question template. DOC Clarify triaging role. Remove usage question template. Aug 13, 2020
@jnothman jnothman merged commit 8c74d98 into scikit-learn:master Aug 13, 2020
@jnothman
Copy link
Copy Markdown
Member

jnothman commented Aug 13, 2020

Thanks @cmarmo

@cmarmo
Copy link
Copy Markdown
Contributor Author

cmarmo commented Aug 13, 2020

... and it works... :) Thanks!
image

@cmarmo cmarmo deleted the triaging branch August 13, 2020 13:56
@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Aug 13, 2020

That is awesome! Thank you @cmarmo !

jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@cmarmo @NicolasHug @jayzed82
DOC Clarify triaging role. Remove usage question template. (scikit-le…
374ac20 
…arn#18142)

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

@glemaitre glemaitre glemaitre approved these changes

+1 more reviewer

@NicolasHug NicolasHug NicolasHug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cmarmo @NicolasHug @jnothman @thomasjpfan @glemaitre