DOC Add user guide for permutation_test_score#18055
Merged
thomasjpfan merged 5 commits intoscikit-learn:masterfrom Aug 13, 2020
Merged
DOC Add user guide for permutation_test_score#18055thomasjpfan merged 5 commits intoscikit-learn:masterfrom
thomasjpfan merged 5 commits intoscikit-learn:masterfrom
Conversation
Member
Author
|
(Also) Should the example |
swierh
suggested changes
Aug 4, 2020
Contributor
swierh
left a comment
There was a problem hiding this comment.
I would be a bit more explicit about that this test only shows that the model reliably outperforms random guessing.
Member
It's true that it would make more sense to move it under model selection but it would change its URL and break links... |
swierh
approved these changes
Aug 5, 2020
ogrisel
reviewed
Aug 6, 2020
ogrisel
reviewed
Aug 6, 2020
Member
ogrisel
left a comment
There was a problem hiding this comment.
Looks great. Here are a few suggestions for further improvements:
ogrisel
approved these changes
Aug 12, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* wip * add user guide * fix link to ex * suggestion * suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follows on from #17373 and #10905
What does this implement/fix? Explain your changes.
Add user guide for
permutation_test_scoreAny other comments?
cc @ogrisel