ENH Add verbose option to SpectralClustering#18052
ENH Add verbose option to SpectralClustering#18052thomasjpfan merged 6 commits intoscikit-learn:masterfrom
Conversation
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @sstalley !
thomasjpfan
left a comment
There was a problem hiding this comment.
Please add an entry to the change log at doc/whats_new/v0.24.rst with tag |Enhancement|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
06be82d to
11a3668
Compare
|
@thomasjpfan the only other potential author would be you (for the f-string formatting in b9c7af8). Also, I wasn't sure of the best way to resolve the merge conflict. I chose to rebase - but now I see that messes up the discussion history in the PR. Is there a preferred method of resolving merge conflicts for this project? |
We normally do not attribute the reviewers, so there is no need to add my name.
We prefer to merge with master and handle the conflicts there. When we merge with master, we will square the commits. For this PR, I pushed to this branch to fix the conflicts and adjust the grammar a little and was about to merge. Edit: I left a review with the changes. |
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Thanks for the explanation. From now on I will ignore conflicts if the code has already been approved. Sorry for getting in your way this time - I'll try not to let it happen again. |
Don't worry about it! It is good to fix the conflicts. In this case, we just so happened to be working on it at the same time. :) |
|
Thank you for working on this @sstalley ! |
Of course. Thanks for your help & review @thomasjpfan ! |
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Added verbose option to spectral_clustering and SpectralClustering, making issues easier to debug.
Resolves #17969.
Any other comments?
This is my first pull request for sklearn (as well as my first pull request using github),
so any feedback or constructive criticism is appreciated. Thanks!