MNT deprecate ChangedBehaviorWarning and NonBLASDotWarning#17804
MNT deprecate ChangedBehaviorWarning and NonBLASDotWarning#17804adrinjalali merged 3 commits intoscikit-learn:masterfrom
Conversation
|
My impression is that we eventually decided to use |
|
NonBLASDotWarning seems to have been used when numpy.dot had speed issues (version < 1.7). I think it has no utility anymore and can be removed safely.
|
|
@jeremiedbb the filter is already removed in this PR, or at least I think it's removed. Don't you see it in the diff? |
|
I specifically checked if you already did it and yet I missed it. The diff is too big :D |
|
The ChangedBehaviorWarning was something we did after changing the behavior, so it's unlike future warning, but I also think it's not a good idea. |
|
#17610 shows a use-case where
I might think that we might need this warning at some point in |
|
I'd say if we think we should give users warning about a change behavior in an experimental module, we're not thinking of it really as experimental and we should move it to stable, and deprecate old behavior as usual. I'd find it odd if we go down the path of warning users about change behavior in a module which is explicitly there for us to change things w/o a warning. |
…arn#17804) * deprecate ChangedBehaviorWarning and NonBLASDotWarning * add whats_new entry
…arn#17804) * deprecate ChangedBehaviorWarning and NonBLASDotWarning * add whats_new entry
Deprecates
ChangedBehaviorWarningandNonBLASDotWarningsince they're not used.ping @NicolasHug @jeremiedbb I don't think we need any of them, do we?