DOC improve attributes and parameters descriptions in KernelPCA#17747
Merged
glemaitre merged 29 commits intoscikit-learn:masterfrom Jun 26, 2020
Merged
DOC improve attributes and parameters descriptions in KernelPCA#17747glemaitre merged 29 commits intoscikit-learn:masterfrom
glemaitre merged 29 commits intoscikit-learn:masterfrom
Conversation
…#14312) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
…into doc_attributes
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
…cikit-learn into doc_attributes
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
NicolasHug
reviewed
Jun 26, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
thanks both, looks good, some minor comments
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
NicolasHug
reviewed
Jun 26, 2020
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
glemaitre
reviewed
Jun 26, 2020
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
approved these changes
Jun 26, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. We will wait that the CIs are passing.
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jul 17, 2020
…it-learn#17747) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…it-learn#17747) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Documentation for the KernelPCA #14312.
What does this implement/fix? Explain your changes.
Improve declarations for parameters and attributes for the class KernelPCA
Any other comments?
Co-authored-by: Beatriz San-Miguel (Beatriz.sanmiguelgonzalez@uk.fujitsu.com)