Skip to content

DOC improve description of OneClassSVM when used for outlier detection#17726

Merged
glemaitre merged 3 commits intoscikit-learn:masterfrom
MLH-Fellowship:outlier-det
Jun 25, 2020
Merged

DOC improve description of OneClassSVM when used for outlier detection#17726
glemaitre merged 3 commits intoscikit-learn:masterfrom
MLH-Fellowship:outlier-det

Conversation

@rubywerman
Copy link
Copy Markdown
Contributor

@rubywerman rubywerman commented Jun 25, 2020

Reference Issues/PRs

Fixes part of #3466
Builds on my PR: #17710

What does this implement/fix? Explain your changes.

Addressed comments from PR: #17710 (fixed line length < 79 chars and reworded second sentence), adds back new line

Any other comments?

@rubywerman
Copy link
Copy Markdown
Contributor Author

rubywerman commented Jun 25, 2020

@glemaitre here are my changes to your comments!

glemaitre
glemaitre reviewed Jun 25, 2020
View reviewed changes
doc/modules/outlier_detection.rst Outdated
:align: center
:scale: 75%

No newline at end of file
Copy link
Copy Markdown
Member

@glemaitre glemaitre Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups you have an indent too much.

@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Jun 25, 2020

You can ignore the CircleCI fail (you can merge master it should be fixed)
Another thing there is no need to open a new branch at each change. You just need to make the change, commit, and push into the same branch. GitHub will synchronize your branch and the PR.

@rubywerman
Copy link
Copy Markdown
Contributor Author

rubywerman commented Jun 25, 2020

Another thing there is no need to open a new branch at each change. You just need to make the change, commit, and push into the same branch. GitHub will synchronize your branch and the PR.

sorry! will work on same branch next time :)

@glemaitre glemaitre changed the title Update description of OneClassSVM for outlier detection DOC improve description of OneClassSVM when used for outlier detection Jun 25, 2020
glemaitre
glemaitre approved these changes Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK LGTM. I am waiting for the documentation CI to pass to look at the rendering once more and I will merge.

@glemaitre glemaitre merged commit 2e47204 into scikit-learn:master Jun 25, 2020
@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Jun 25, 2020

Thanks @rubywerman

@rubywerman rubywerman deleted the outlier-det branch June 25, 2020 16:55
@rubywerman rubywerman restored the outlier-det branch June 25, 2020 21:29
@rubywerman rubywerman mentioned this pull request Jun 25, 2020
Merged
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
@rubywerman @glemaitre
DOC improve description of OneClassSVM when used for outlier detection (
443b9d0 
scikit-learn#17726)
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@rubywerman @jayzed82
DOC improve description of OneClassSVM when used for outlier detection (
7def157 
scikit-learn#17726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rubywerman @glemaitre