Skip to content

DOC add explanation of n_jobs in permutation_importance#17723

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
hs-nazuna:doc_perm_importance
Jun 25, 2020
Merged

DOC add explanation of n_jobs in permutation_importance#17723
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
hs-nazuna:doc_perm_importance

Conversation

@hs-nazuna
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

See #14228

What does this implement/fix? Explain your changes.

Add more helpful documentation for n_jobs in sklearn/inspection/_permutation_importance.py.

Any other comments?

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Jun 25, 2020

I believe the CI failure is unrelated. You might want to merge master again into this branch to see if the fix for the failure has been successfully applied to master.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC add explanation of n_jobs in inspection/_permutation_importance.py DOC add explanation of n_jobs in permutation_importance Jun 25, 2020
@thomasjpfan thomasjpfan merged commit 67e24a4 into scikit-learn:master Jun 25, 2020
@hs-nazuna hs-nazuna deleted the doc_perm_importance branch June 25, 2020 15:23
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants