Skip to content

DOC improve attributes and parameters descriptions in RFE and RFECV#17721

Merged
glemaitre merged 15 commits intoscikit-learn:masterfrom
kcetina-fujitsu:doc_rfe
Jun 25, 2020
Merged

DOC improve attributes and parameters descriptions in RFE and RFECV#17721
glemaitre merged 15 commits intoscikit-learn:masterfrom
kcetina-fujitsu:doc_rfe

Conversation

@kcetina-fujitsu
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Documentation for the RFE and RFECV #14312.

What does this implement/fix? Explain your changes.

Improve declarations for parameters and attributes for the class RFE and RFECV

Any other comments?

Co-authored-by: Beatriz San-Miguel (Beatriz.sanmiguelgonzalez@uk.fujitsu.com)

@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Jun 25, 2020

Uhm the failures are weird. CircleCI should be fixed quite soon but I don't get the rest. Could merge master into your branch.
Otherwise, your changes seem correct.

'ElasticNetCV',
'KernelCenterer',
'LarsCV', 'Lasso', 'LassoLarsCV', 'LassoLarsIC',
'LocalOutlierFactor', 'MiniBatchKMeans',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this 2 is causing the failure on Azure.

@glemaitre glemaitre merged commit 2c71070 into scikit-learn:master Jun 25, 2020
@glemaitre
Copy link
Copy Markdown
Member

Thanks @kcetina-fujitsu

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
…cikit-learn#17721)

Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
…cikit-learn#17721)

Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants