Skip to content

MNT Fetch numpy and scipy nightly wheels from anaconda#17672

Merged
thomasjpfan merged 3 commits intoscikit-learn:masterfrom
alfaro96:fetch_numpy_scipy_anaconda
Jun 23, 2020
Merged

MNT Fetch numpy and scipy nightly wheels from anaconda#17672
thomasjpfan merged 3 commits intoscikit-learn:masterfrom
alfaro96:fetch_numpy_scipy_anaconda

Conversation

@alfaro96
Copy link
Copy Markdown
Member

@alfaro96 alfaro96 commented Jun 23, 2020 •
edited
Loading

Reference Issues/PRs

Closes #16413.

What does this implement/fix? Explain your changes.

This PR updates the CRON job to fetch the nightly wheels of numpy and scipy from Anaconda instead of the Rackspace container.

Any other comments?

Cython should be still fetched from the Rackspace container.

@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Jun 23, 2020 •
edited
Loading

Yea...I would be happy to help Cython migrate to the anaconda index. (I'll put together the PR to their build repo and someone else needs to set up the API keys)

REF: MacPython/cython-wheels#3

@alfaro96
Copy link
Copy Markdown
Member Author

alfaro96 commented Jun 23, 2020 •
edited
Loading

Yea...I would be happy to help Cython migrate to the anaconda index. (I'll put together the PR to their build repo and someone else needs to set up the API keys)

REF: MacPython/cython-wheels#3

I think that the same approach that was followed for Scikit-learn wheel builder should be also valid for the Cython wheel builder.

I will watch the repository to update this PR when Cython migrates to the Anaconda index.

thomasjpfan
thomasjpfan approved these changes Jun 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are merge this for now and then update when cython uploads its new wheels to the anaconda index.

Thank you for the PR @alfaro96 !

XREF https://github.com/MacPython/cython-wheels/pulls

@alfaro96
Copy link
Copy Markdown
Member Author

alfaro96 commented Jun 23, 2020 •
edited
Loading

We are merge this for now and then update when cython uploads its new wheels to the anaconda index.

Thank you for the PR @alfaro96 !

XREF https://github.com/MacPython/cython-wheels/pulls

Thanks for the review @thomasjpfan!

I have seen that you made a PR in MacPython/cython-wheels#4 to upload the Cython wheels to the Anaconda index. I will watch to this PR to update the CRON job as far as it gets merged.

@alfaro96 alfaro96 closed this Jun 23, 2020
@alfaro96 alfaro96 reopened this Jun 23, 2020
@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Jun 23, 2020

The error in travis is valid and should be fixed in another PR. numpy has been thinking of deprecating np.int and the rest for a while. It looks like they will deprecating it now: numpy/numpy#14882

@thomasjpfan thomasjpfan merged commit 2eb0fbd into scikit-learn:master Jun 23, 2020
@alfaro96 alfaro96 mentioned this pull request Jun 24, 2020
Merged
@alfaro96 alfaro96 deleted the fetch_numpy_scipy_anaconda branch June 24, 2020 11:50
rubywerman pushed a commit to MLH-Fellowship/scikit-learn that referenced this pull request Jun 24, 2020
@alfaro96 @rubywerman
MNT Fetch numpy and scipy nightly wheels from anaconda (scikit-learn#…
abc2e57 
…17672)
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
MNT Fetch numpy and scipy nightly wheels from anaconda (scikit-learn#…
5152b37 
…17672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update nightly-build CI to fetch numpy and scipy wheels from elsewhere

2 participants

@alfaro96 @thomasjpfan