CI Ignore tostring deprecation in numpy 1.19 caused by joblib and scipy. #17652
Merged
rth merged 9 commits intoscikit-learn:masterfrom Jun 22, 2020
Merged
CI Ignore tostring deprecation in numpy 1.19 caused by joblib and scipy. #17652rth merged 9 commits intoscikit-learn:masterfrom
rth merged 9 commits intoscikit-learn:masterfrom
Conversation
This reverts commit ebefb2b.
jnothman
approved these changes
Jun 21, 2020
rth
approved these changes
Jun 22, 2020
Member
rth
left a comment
There was a problem hiding this comment.
Thanks! Would you mind opening an issue about it?
rubywerman
pushed a commit
to MLH-Fellowship/scikit-learn
that referenced
this pull request
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs and master are failing because scipy and joblib are using
tostringwhich has been deprecated in numpy 1.19.This quick patch is to ignore the deprecation warnings the starts with 'tostring'.