Skip to content

Replace *kwargs with named arguments in make_column_transformer#17623

Merged
rth merged 2 commits intoscikit-learn:masterfrom
jaketae:make-column-transform-args
Jun 17, 2020
Merged

Replace *kwargs with named arguments in make_column_transformer#17623
rth merged 2 commits intoscikit-learn:masterfrom
jaketae:make-column-transform-args

Conversation

@jaketae
Copy link
Copy Markdown
Contributor

@jaketae jaketae commented Jun 17, 2020

Reference Issues/PRs

Closes #17345.

What does this implement/fix? Explain your changes.

This PR replaces **kwargs with named arguments for the make_column_transformer() function.

Any other comments?

@jaketae jaketae changed the title Make column transform args [MGR] Replace *kwargs with named arguments in make_column_transformer Jun 17, 2020
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for finishing this up @jaketae !

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaketae !

@rth rth changed the title [MGR] Replace *kwargs with named arguments in make_column_transformer Replace *kwargs with named arguments in make_column_transformer Jun 17, 2020
@rth rth merged commit 493f167 into scikit-learn:master Jun 17, 2020
@reshamas
Copy link
Copy Markdown
Member

#DataUmbrella

dsandeep0138 pushed a commit to dsandeep0138/scikit-learn that referenced this pull request Jun 21, 2020
rubywerman pushed a commit to MLH-Fellowship/scikit-learn that referenced this pull request Jun 24, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPRINT] Functions with *args can now have explicit keyword args

4 participants