DOC doc adding warning to power transform on data leakage and reverts unrelated PR's#17535
Merged
rth merged 18 commits intoscikit-learn:masterfrom Jun 9, 2020
Merged
DOC doc adding warning to power transform on data leakage and reverts unrelated PR's#17535rth merged 18 commits intoscikit-learn:masterfrom
rth merged 18 commits intoscikit-learn:masterfrom
Conversation
…ith in the comment
…into doc_dictlearning
…into doc_powertransform
Member
|
Thanks! Please check the linting errors :) |
…into doc_power
…d power transform warning
adrinjalali
reviewed
Jun 9, 2020
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Please commit to the same branch as this PR instead of opening a new one.
Update on a line rendering adding (.) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
adrinjalali
approved these changes
Jun 9, 2020
…a.py There was a typo in the word "training"
rth
approved these changes
Jun 9, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partly fixes #17402
What does this implement/fix? Explain your changes.
Adds warning about data leakage to power_transform function
Reverts various commentary changes that were unrelated.
Solves Linting errors.
Any other comments?
with @adrinjalali #DataUmbrella