[MRG] DOC standardize default values manifold _isomap _locally_linear#17520
Merged
adrinjalali merged 31 commits intoscikit-learn:masterfrom Jun 8, 2020
amy12xx:doc_manifold
Merged
[MRG] DOC standardize default values manifold _isomap _locally_linear#17520adrinjalali merged 31 commits intoscikit-learn:masterfrom amy12xx:doc_manifold
adrinjalali merged 31 commits intoscikit-learn:masterfrom
amy12xx:doc_manifold
Conversation
glemaitre
reviewed
Jun 7, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
On the same line as your changes, I think that it is worth correcting the dtype as well. It will avoid making a new PR.
DOC standardize default values manifold _isomap _locally_linear DOC standardize default values in _locally_linear
update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
DOC standardize default values manifold _isomap _locally_linear DOC standardize default values in _locally_linear
update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…into doc_manifold
fix default vals Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
fixed default vals Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…it-learn#17520) * DOC standardize default values manifold _isomap _locally_linear DOC standardize default values manifold _isomap _locally_linear DOC standardize default values in _locally_linear * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * fixed default values _locally_linear * DOC standardize default values manifold _isomap _locally_linear DOC standardize default values manifold _isomap _locally_linear DOC standardize default values in _locally_linear * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * fixed default values _locally_linear * fixed pylint issue * Update sklearn/manifold/_locally_linear.py fix default vals Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fixed default vals Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * fix pylint * fix docstring Co-authored-by: Amanda Dsouza <adsouza41@gatech.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…it-learn#17520) * DOC standardize default values manifold _isomap _locally_linear DOC standardize default values manifold _isomap _locally_linear DOC standardize default values in _locally_linear * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * fixed default values _locally_linear * DOC standardize default values manifold _isomap _locally_linear DOC standardize default values manifold _isomap _locally_linear DOC standardize default values in _locally_linear * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py update dtype Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_isomap.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix dtype in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fix options in docstring Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * fixed default values _locally_linear * fixed pylint issue * Update sklearn/manifold/_locally_linear.py fix default vals Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Update sklearn/manifold/_locally_linear.py fixed default vals Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * fix pylint * fix docstring Co-authored-by: Amanda Dsouza <adsouza41@gatech.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References Issue #15761
What does this implement/fix? Explain your changes.
standardize default values in manifold module for the following:
_isomap.py
_locally_linear.py
#DataUmbrella