DOC_standardized formatting for default values in transformer class.#17505
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Jun 6, 2020
ezebunandu:doc_default_values_preprocessing_transformer
Merged
DOC_standardized formatting for default values in transformer class.#17505thomasjpfan merged 2 commits intoscikit-learn:masterfrom ezebunandu:doc_default_values_preprocessing_transformer
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
ezebunandu:doc_default_values_preprocessing_transformer
Conversation
thomasjpfan
reviewed
Jun 6, 2020
Member
There was a problem hiding this comment.
Thank you for the PR @ezebunandu
The guide recommends using the python basic types (bool).
Contributor
Author
thomasjpfan
approved these changes
Jun 6, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM! Thank you @amy12xx and @ezebunandu !
Member
|
#DataUmbrella sprint |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…cikit-learn#17505) * DOC_standardized formatting for default values in transformer class. * DOC_use type bool instead of boolean Co-authored-by: Sam Ezebunandu <samuel.ezebunandu@outlook.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…cikit-learn#17505) * DOC_standardized formatting for default values in transformer class. * DOC_use type bool instead of boolean Co-authored-by: Sam Ezebunandu <samuel.ezebunandu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MRG] References Issue #15761
Standardized formatting for default values in the preprocessing.FunctionTransformer class.
cc: @amy12xx