DOC added a warning to maxabs_scale to prevent data leakage#17487
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Jun 6, 2020
Merged
DOC added a warning to maxabs_scale to prevent data leakage#17487thomasjpfan merged 2 commits intoscikit-learn:masterfrom
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
Conversation
NicolasHug
approved these changes
Jun 6, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @krumeto and @CeeThinwa, looks good!
will wait for CI to go green before merging
NicolasHug
reviewed
Jun 6, 2020
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
thomasjpfan
approved these changes
Jun 6, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @krumeto and @CeeThinwa !
Member
|
#DataUmbrella sprint |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…earn#17487) * added a warning to maxabs_scale * Update sklearn/preprocessing/_data.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Krum Arnaudov <krum.arnaudov@amplifyanalytix.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…earn#17487) * added a warning to maxabs_scale * Update sklearn/preprocessing/_data.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Krum Arnaudov <krum.arnaudov@amplifyanalytix.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs #17402
What does this implement/fix? Explain your changes.
I added a warning to maxabs_scale suggesting users to use MaxAbsScaler in Pipeline instead to prevent data leakage
Any other comments?
cc: (pair programming partner) @CeeThinwa