ENH add score_samples method in base search CV and add tests#17478
Merged
adrinjalali merged 9 commits intoscikit-learn:masterfrom Jun 8, 2020
Merged
ENH add score_samples method in base search CV and add tests#17478adrinjalali merged 9 commits intoscikit-learn:masterfrom
adrinjalali merged 9 commits intoscikit-learn:masterfrom
Conversation
Member
|
cc @thomasjpfan who reviewed the previous PR |
amueller
reviewed
Jun 6, 2020
Member
|
Please fix the linting issues :) |
thomasjpfan
reviewed
Jun 6, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @teonbrooks !
thomasjpfan
reviewed
Jun 6, 2020
thomasjpfan
reviewed
Jun 6, 2020
thomasjpfan
approved these changes
Jun 6, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM Thank you for the PR @teonbrooks !
Member
|
Please add an entry to the change log at |
thomasjpfan
reviewed
Jun 6, 2020
Member
|
#DataUmbrella sprint |
fix indenting
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
* add score_samples method in base search CV and add tests * add tests and change implem * fix pep8 * address some pr comments * Update test_search.py remove deprecation warnings * address some linting issues * Update test_search.py * update whats_new fix indenting * update test_search.py Co-authored-by: Mohamed Maskani <maskani.mohamed@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* add score_samples method in base search CV and add tests * add tests and change implem * fix pep8 * address some pr comments * Update test_search.py remove deprecation warnings * address some linting issues * Update test_search.py * update whats_new fix indenting * update test_search.py Co-authored-by: Mohamed Maskani <maskani.mohamed@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12542.
Building on and closes #16275.
What does this implement/fix? Explain your changes.
This adds the ability to call
score_sampleson the estimator with the best found parameters in *SearchCV instances.