[MRG] Issue #17345: Added keyword arguments to Shuffle#17474
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom Jun 6, 2020
JosephTLucas:explicit-keywords-shuffle
Merged
[MRG] Issue #17345: Added keyword arguments to Shuffle#17474thomasjpfan merged 1 commit intoscikit-learn:masterfrom JosephTLucas:explicit-keywords-shuffle
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
JosephTLucas:explicit-keywords-shuffle
Conversation
Added random_state and n_samples Modified documentation to reflect default values Modified call to resample
Member
|
@JosephTLucas Congrats! Under Description, can you add your pair partner as: |
Member
|
The test failure seems to be a random timeout, I'm trying to run it again. |
thomasjpfan
approved these changes
Jun 6, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM, Thank you @ab-anssi and @JosephTLucas !
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
Added random_state and n_samples Modified documentation to reflect default values Modified call to resample
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Added random_state and n_samples Modified documentation to reflect default values Modified call to resample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#DataUmbrella
Work with: https://github.com/ab-anssi
cc: @ab-anssi
Added random_state and n_samples
Modified documentation to reflect default values
Modified call to resample
Reference Issues/PRs
Issue #17345
What does this implement/fix? Explain your changes.
Adds keyword arguments to shuffle function to for Issue #17345
Any other comments?