ENH Replace *args with named arguments in make_union#17472
ENH Replace *args with named arguments in make_union#17472thomasjpfan merged 12 commits intoscikit-learn:masterfrom jaketae:make-union-args
Conversation
|
This looks good, is this still work in progress? |
|
@amueller I think we're done now! The import orders were jumbled up, so I reverted them back to how they were (as per your note in the other PR). Thanks! |
|
Looks good, thanks! Let's wait for CI. |
|
There's a test failure in |
|
You need to change the expected error message in that test. |
|
@amueller, I'm slightly confused as to how the error message should be modified. I think this is the part that needs fixing: I changed the error message to |
|
That's exactly right. CI is a bit slow right now, have you run the tests locally? You can do |
|
@amueller I was just doing that, and can now confirm that all tests pass on my local. Thank you! |
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @jaketae !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Reference Issues/PRs
Partially addresses #17402.
What does this implement/fix? Explain your changes.
Any other comments?
This PR is part of the Data Umbrella Scikit-learn Sprint. #DataUmbrella