[MRG] DOC Fix documentation of default values in cluster module#17455
Merged
thomasjpfan merged 4 commits intomasterfrom Jun 7, 2020
unknown repository
Merged
[MRG] DOC Fix documentation of default values in cluster module#17455thomasjpfan merged 4 commits intomasterfrom unknown repository
thomasjpfan merged 4 commits intomasterfrom
unknown repository
Conversation
alfaro96
reviewed
Jun 5, 2020
Member
alfaro96
left a comment
There was a problem hiding this comment.
Thanks @pgithubs!
I provide some minor comments.
Author
|
Thanks for the review @alfaro96 , I've made those changes now. |
alfaro96
suggested changes
Jun 6, 2020
Member
alfaro96
left a comment
There was a problem hiding this comment.
LGTM when these changes are applied.
Thanks @pgithubs!
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…rn#17455) * updated _affinity_propagation.py docstrings in line with scikit-learn#15761 * updated cluster module docstrings in line with scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 Co-authored-by: Greg Knowles <gitgreg123@users.noreply.github.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…rn#17455) * updated _affinity_propagation.py docstrings in line with scikit-learn#15761 * updated cluster module docstrings in line with scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 Co-authored-by: Greg Knowles <gitgreg123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Delivers towards #15761
What does this implement/fix? Explain your changes.
Makes changes to docstrings to remove optional and specify default=None. Also some generic docstring updates inline with guidance.
Any other comments?
This only delivers updates to the cluster module