MNT fix section order of what's new v0.24#17437
Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom Jun 3, 2020
Merged
MNT fix section order of what's new v0.24#17437NicolasHug merged 2 commits intoscikit-learn:masterfrom
NicolasHug merged 2 commits intoscikit-learn:masterfrom
Conversation
thomasjpfan
reviewed
Jun 3, 2020
doc/whats_new/v0.24.rst
Outdated
Comment on lines
+71
to
+73
| - |Enhancement| Add `sample_weight` parameter to | ||
| :class:`metrics.median_absolute_error`. | ||
| :pr:`17225` by :user:`Lucy Liu <lucyleeow>`. |
Member
There was a problem hiding this comment.
Space above this and use up more of the 80 characters?
Member
Author
There was a problem hiding this comment.
Couldn't do <2 lines without going over 80 characters.
doc/whats_new/v0.24.rst
Outdated
Comment on lines
+84
to
+86
| :mod:`sklearn.feature_selection` | ||
| ................................ | ||
|
|
Member
There was a problem hiding this comment.
This section (and its contents) should be higher up so that the modules are in alphabetical order.
Member
|
Happy to merge this when comments are addressed, but FYI we usually do these kind of fixes just before the release. Other discrepancies will come up and we'd rather fix them once |
Member
Author
|
Thanks @NicolasHug - I might just delete the PR then, what do you think? (I noticed this on a merge conflict and it just annoyed me) |
Member
|
since it's already open and reviewed we might as well just merge it ;) |
TomDLT
approved these changes
Jun 3, 2020
NicolasHug
approved these changes
Jun 3, 2020
Member
|
thanks @lucyleeow |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Put
metricselements under same headerPut
feature_selectionelement under correct headerAny other comments?