Skip to content

MNT Deprecate coef_ and intercept_ in naive bayes estimators#17427

Merged
jnothman merged 12 commits intoscikit-learn:masterfrom
alfaro96:deprecate_coef_intercept_naive_bayes
Jul 5, 2020
Merged

MNT Deprecate coef_ and intercept_ in naive bayes estimators#17427
jnothman merged 12 commits intoscikit-learn:masterfrom
alfaro96:deprecate_coef_intercept_naive_bayes

Conversation

@alfaro96
Copy link
Copy Markdown
Member

@alfaro96 alfaro96 commented Jun 2, 2020

Reference Issues/PRs

Closes #2237.

What does this implement/fix? Explain your changes.

This PR deprecates the attributes coef_ and intercept_ in sklearn.naive_bayes.MultinomialNB, sklearn.naive_bayes.BernoulliNB and sklearn.naive_bayes.CategoricalNB.

@alfaro96 alfaro96 changed the title Deprecate coef intercept naive bayes MNT Deprecate coef_ and intercept_ in naive bayes estimators Jun 2, 2020
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @alfaro96

@alfaro96
Copy link
Copy Markdown
Member Author

alfaro96 commented Jun 4, 2020

Thank you for the PR @alfaro96

Thanks for the review @thomasjpfan!

@glemaitre
Copy link
Copy Markdown
Member

@alfaro96 We are going to introduce the attributes coef_ and intercept_ in the documentation for completness: #17722

Once merged, I think your PR can add the .. deprecated:: tag in the documentation as well.

@alfaro96
Copy link
Copy Markdown
Member Author

@alfaro96 We are going to introduce the attributes coef_ and intercept_ in the documentation for completness: #17722

Once merged, I think your PR can add the .. deprecated:: tag in the documentation as well.

Sure. Go ahead!

@alfaro96 alfaro96 requested a review from thomasjpfan July 1, 2020 10:07
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnothman
Copy link
Copy Markdown
Member

jnothman commented Jul 5, 2020

Thanks @alfaro96

@jnothman jnothman merged commit 3561802 into scikit-learn:master Jul 5, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 alfaro96 deleted the deprecate_coef_intercept_naive_bayes branch November 11, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naive Bayes has the wrong coef_ and intercept_

4 participants