DOC Fixes hard coded title in gmm selection example plot#17418
Merged
rth merged 5 commits intoscikit-learn:masterfrom Aug 7, 2020
Merged
DOC Fixes hard coded title in gmm selection example plot#17418rth merged 5 commits intoscikit-learn:masterfrom
rth merged 5 commits intoscikit-learn:masterfrom
Conversation
thomasjpfan
reviewed
Jun 1, 2020
thomasjpfan
reviewed
Jun 1, 2020
Member
|
For future reference, it's good to put "Fixes ISSUE_NUMBER" in your opening message, this would cause github to automatically close the issue this PR is resolving. |
cmarmo
reviewed
Jul 16, 2020
Comment on lines
+97
to
+98
| plt.title('Selected GMM: {} model, {} components'.format( | ||
| best_gmm.covariance_type, best_gmm.n_components)) |
Contributor
There was a problem hiding this comment.
Hi @tbenjamin-pl what about using a f-string here?
rth
reviewed
Aug 7, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…n#17418) Co-authored-by: Thomas S. Benjamin <tbenjamin@vencorelabs.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #17408
What does this implement/fix? Explain your changes.
Any other comments?