DOC Update preprocessor in CountVectorizer#17413
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom Jun 1, 2020
Merged
DOC Update preprocessor in CountVectorizer#17413thomasjpfan merged 1 commit intoscikit-learn:masterfrom
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
Conversation
rth
approved these changes
Jun 1, 2020
thomasjpfan
approved these changes
Jun 1, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
I see this is your first time contributing, welcome @yagi-3 !
LGTM
Member
|
I think we had a pull request a while back to warn when parameters to text vectorisers were being overridden by other parameters. Afk now I don't recall if it was merged |
Member
|
applied to #DataUmbrella sprint |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #17348. @venkyyuvy, thank you for your finding.
What does this implement/fix?
One minor change:
preprocessorargument in CountVectorizer is updated to show which processes are overrode.Any other comments?
lowercaseandstrip_accentswhenpreprocessoris not None, code modification is needed(maybe build_preprocessor function in _VectorizerMixin class).