DOC Emphasized determinism of ParameterGrid in docs#17383
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Jun 1, 2020
Merged
DOC Emphasized determinism of ParameterGrid in docs#17383thomasjpfan merged 2 commits intoscikit-learn:masterfrom
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
Conversation
NicolasHug
approved these changes
May 29, 2020
Member
There was a problem hiding this comment.
Thanks @zaccharieramzi , minor suggestion
Since this is a documentation matter, I understood I could directly submit a PR rather than first writing an issue.
yes that's the preferred workflow 👍
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
thomasjpfan
approved these changes
Jun 1, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you @zaccharieramzi
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Since this is a documentation matter, I understood I could directly submit a PR rather than first writing an issue. If this is not the case I am happy to write an issue about this.
What does this implement/fix? Explain your changes.
I emphasized the fact that the parameter grid gives deterministic results. It was important to know in one of my use cases, and I found out that it was thanks to this line of code.
Any other comments?
I see that there are no unit tests for this, so I don't know if this property is there to stay.
Maybe adding a test for this would be nice, but I wouldn't really know how to go about it.