DOC Adds note on dataframe in contributing guide#17359
Merged
adrinjalali merged 2 commits intoscikit-learn:masterfrom Jun 25, 2020
Merged
DOC Adds note on dataframe in contributing guide#17359adrinjalali merged 2 commits intoscikit-learn:masterfrom
adrinjalali merged 2 commits intoscikit-learn:masterfrom
Conversation
glemaitre
reviewed
May 27, 2020
doc/developers/contributing.rst
Outdated
| ``{array-like, ndarray, sparse matrix, dataframe}``. Note that ``array-like`` | ||
| can also be a ``list``, while ``ndarray`` is explicitly only a ``numpy.ndarray``. | ||
| 5. When specifying the data type of a list, use ``of`` as a delimiter: | ||
| 5. Specific ``dataframe`` when "frame-like" features are being used, such |
Member
There was a problem hiding this comment.
I might remove dataframe from l. 677 example because in most cases we will not have to specify it then.
glemaitre
approved these changes
May 27, 2020
adrinjalali
approved these changes
Jun 25, 2020
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jul 17, 2020
* DOC Adds note on dataframe * DOC Address comments
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* DOC Adds note on dataframe * DOC Address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed during the monthly call, this PR adds documentation regarding using
dataframein a docstring.CC @glemaitre