TST Remove Boston dataset in test_mlp#17337
Merged
thomasjpfan merged 7 commits intoscikit-learn:masterfrom May 26, 2020
Merged
Conversation
lucyleeow
commented
May 25, 2020
| for activation in ACTIVATION_TYPES: | ||
| mlp = MLPRegressor(solver='lbfgs', hidden_layer_sizes=50, | ||
| print(f'{activation}') | ||
| mlp = MLPRegressor(solver='lbfgs', hidden_layer_sizes=50, tol=0.0, |
Member
Author
There was a problem hiding this comment.
set tol=0.0 otherwise convergence occurs <10 iterations for 'identity'
lucyleeow
commented
May 25, 2020
|
|
||
| pred2 = mlp.predict(X) | ||
| assert_almost_equal(pred1, pred2, decimal=2) | ||
| assert_almost_equal(pred1, pred2) |
Member
Author
There was a problem hiding this comment.
Removed decimal=2 to use the default decimal=7 as the predictions should be/are equal to more precision.
Member
Author
|
(cc @glemaitre ) |
glemaitre
reviewed
May 25, 2020
|
|
||
| pred2 = mlp.predict(X) | ||
| assert_almost_equal(pred1, pred2, decimal=2) | ||
| assert_almost_equal(pred1, pred2) |
Member
There was a problem hiding this comment.
we should be use assert_allclose if we are changing it.
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #16155
What does this implement/fix? Explain your changes.
Use synthetic dataset instead of Boston dataset
Any other comments?
Notes added as review comments for easier legibility