MNT Replace kwargs by named args for resample#17324
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom May 25, 2020
Merged
MNT Replace kwargs by named args for resample#17324jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
thomasjpfan
approved these changes
May 24, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM Thank you @alfaro96 !
Member
Author
|
Thanks for the quick review @thomasjpfan! |
Member
|
Oh. I'd not seen this and just opened #17345 about it. Hmm I should check if there are other instances |
jnothman
approved these changes
May 25, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #15761.
What does this implement/fix? Explain your changes.
Replaces the keyword arguments by named arguments in the
sklearn.utils.resamplefunction. This should help with maintenance and make easier to understand the documentation.