Skip to content

MNT Enables subset_invariance tests to run with SparsePCA#17319

Merged
rth merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:remove_sparsepca_from_special_case
Jun 3, 2020
Merged

MNT Enables subset_invariance tests to run with SparsePCA#17319
rth merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:remove_sparsepca_from_special_case

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

With #11585, these the *SparsePCA now passes check_methods_subset_invariance.

@thomasjpfan
Copy link
Copy Markdown
Member Author

@NicolasHug @rth Easy review?

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rth
Copy link
Copy Markdown
Member

rth commented Jun 3, 2020

Great!

@rth rth merged commit b364028 into scikit-learn:master Jun 3, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@rth rth mentioned this pull request Jul 25, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants