Skip to content

[MRG] Modify RandomizedSearchCV's docstring#17275

Merged
glemaitre merged 1 commit intoscikit-learn:masterfrom
barberogaston:fix_randomized_search_cv_docs
May 20, 2020
Merged

[MRG] Modify RandomizedSearchCV's docstring#17275
glemaitre merged 1 commit intoscikit-learn:masterfrom
barberogaston:fix_randomized_search_cv_docs

Conversation

@barberogaston
Copy link
Copy Markdown
Contributor

@barberogaston barberogaston commented May 18, 2020

Reference Issues/PRs

Closes #17267

What does this implement/fix? Explain your changes.

This PR fixes RandomizedSearchCV's docstring in the cv_results_ attribute section where the given example has wrong rank_test_score scores given the values in the mean_test_score list.

Any other comments?

Acknowledgements to @NicolasHorMann for realizing this too.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @barberogaston !

LGTM

@glemaitre glemaitre merged commit 26b2678 into scikit-learn:master May 20, 2020
@glemaitre
Copy link
Copy Markdown
Member

Thanks @barberogaston

@barberogaston barberogaston deleted the fix_randomized_search_cv_docs branch May 20, 2020 13:39
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RandomizedSearchCV - Highest mean_test_score doesn't have rank 1 in rank_test_score in cv_results_

3 participants