Skip to content

DOC update whatsnew_0.23 with removal of _safe_tags()#17245

Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom
rtavenar:doc_deprecate_safe_tags
May 15, 2020
Merged

DOC update whatsnew_0.23 with removal of _safe_tags()#17245
NicolasHug merged 2 commits intoscikit-learn:masterfrom
rtavenar:doc_deprecate_safe_tags

Conversation

@rtavenar
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #17232

What does this implement/fix? Explain your changes.

Document the removal of _safe_tags from utils.estimator_checks in v0.23.

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small addition to clarify that it's not a deprecation, and also to provide tips on how to make it work

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@thomasjpfan thomasjpfan added this to the 0.23.1 milestone May 15, 2020
@NicolasHug NicolasHug changed the title DOC Add info about the deprecation of _safe_tags in v0.23 changelog DOC update whatsnew_0.23 with removal of _safe_tags() May 15, 2020
@NicolasHug NicolasHug merged commit 05e4c92 into scikit-learn:master May 15, 2020
@NicolasHug
Copy link
Copy Markdown
Member

Thanks @rtavenar

@rtavenar rtavenar deleted the doc_deprecate_safe_tags branch May 15, 2020 17:26
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention the deprecation of _safe_tags in 0.23 release notes

3 participants