Skip to content

[MRG] MNT Removed name parameter from private check generators#17224

Merged
rth merged 3 commits intoscikit-learn:masterfrom
NicolasHug:remove_name_from_checks
May 15, 2020
Merged

[MRG] MNT Removed name parameter from private check generators#17224
rth merged 3 commits intoscikit-learn:masterfrom
NicolasHug:remove_name_from_checks

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

No description provided.

@NicolasHug
Copy link
Copy Markdown
Member Author

CC @rth @thomasjpfan

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rth
Copy link
Copy Markdown
Member

rth commented May 15, 2020

Could you please resolve conflicts?

@rth
Copy link
Copy Markdown
Member

rth commented May 15, 2020

There is one occurence left in parametrize_with_checks I think.

@NicolasHug
Copy link
Copy Markdown
Member Author

all green now!

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit d03dfa2 into scikit-learn:master May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants