Skip to content

[MRG] Fix path to what's new in the navigation bar#17223

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
alfaro96:fix_path_whats_new_navigation_bar
May 14, 2020
Merged

[MRG] Fix path to what's new in the navigation bar#17223
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
alfaro96:fix_path_whats_new_navigation_bar

Conversation

@alfaro96
Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Fixes the path to what's new in the navigation bar. Currently, the pathto Jinja function is not used to refer to the corresponding built document. Thus, Jinja assumes that this document is within the same folder of the current HTML page, which is true only in the root folder.

To reproduce this issue:

  1. Go to API Reference
  2. Click on the What's new item in the More drop-down list.

This should fix this issue. @thomasjpfan What do you think?

@thomasjpfan thomasjpfan added this to the 0.23.1 milestone May 14, 2020
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alfaro96 !

@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented May 14, 2020

@adrinjalali I added this to the milestone to be included in the next bug-fix release.

@thomasjpfan thomasjpfan merged commit bbab854 into scikit-learn:master May 14, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
@alfaro96 alfaro96 deleted the fix_path_whats_new_navigation_bar branch May 20, 2020 07:34
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants