MNT Ignore xfail_checks tag in check_estimator, with warning#17222
Merged
NicolasHug merged 8 commits intoscikit-learn:masterfrom May 15, 2020
Merged
Conversation
thomasjpfan
approved these changes
May 14, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
In this case, xfail_checks skips the whole test and raises a warning. I think I am happy with this.
| checks_generator = chain.from_iterable( | ||
| check_estimator(estimator, generate_only=True) | ||
| for estimator in estimators) | ||
| names = (type(estimator).__name__ for estimator in estimators) |
rth
reviewed
May 15, 2020
rth
approved these changes
May 15, 2020
Member
rth
left a comment
There was a problem hiding this comment.
Minor improvement otherwise LGTM!
I'll add Thomas as co-author when merging given all the work he did on this.
This reverts commit ee44848.
Member
Author
|
Merging, thanks for the reviews, I put you both as co-authors |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…learn#17222) Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…learn#17222) Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16958
Alternative to and Closes #16963
Alternative to and Closes #17219
Same as #17219 , but raises a warning when a check is skipped.
CC @rth @thomasjpfan