Fix argument ref in Isomap docs#17217
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom May 14, 2020
Merged
Conversation
hugolmn
approved these changes
May 14, 2020
Contributor
|
Good job on spotting this mistake! Looks like it was copy-pasted from just above in the documentation |
thomasjpfan
approved these changes
May 14, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM Thank you @AdamSpannbauer !
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 18, 2020
adrinjalali
pushed a commit
that referenced
this pull request
May 19, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
I didn't find an open issue for this.
What does this implement/fix? Explain your changes.
Isomapdocumentation on the manifold module documentation incorrectly references thepath_methodargument:This PR simply updates
path_methodtoeigen_solver:Any other comments?
Link to
Isomapsource in case it's relevant.