FIX changed_only=True with kwargs parameters#17205
Merged
NicolasHug merged 7 commits intoscikit-learn:masterfrom May 13, 2020
Merged
FIX changed_only=True with kwargs parameters#17205NicolasHug merged 7 commits intoscikit-learn:masterfrom
NicolasHug merged 7 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
May 13, 2020
jnothman
reviewed
May 13, 2020
sklearn/utils/tests/test_pprint.py
Outdated
| from lightgbm import LGBMClassifier # noqa | ||
|
|
||
| # metric is part of **kwargs | ||
| est = LGBMClassifier(metric='auc', max_depth=10) |
Member
There was a problem hiding this comment.
should test something=None for non-regression?
sklearn/utils/tests/test_pprint.py
Outdated
| # https://github.com/scikit-learn/scikit-learn/issues/17206 | ||
|
|
||
| pytest.importorskip("lightgbm") | ||
| from lightgbm import LGBMClassifier # noqa |
Member
There was a problem hiding this comment.
better to implement something with def __init__(**kw) here??
jnothman
approved these changes
May 13, 2020
Member
jnothman
left a comment
There was a problem hiding this comment.
yeah, LightGBM does weird stuff with get_params. But this is a good fix.
Member
|
Please update what's new for 0.23.1 |
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
Member
Author
|
Thanks for the reviews! @adrinjalali is there a PR/issue to tag for inclusion into 0.23.1? |
Member
|
No I just created the milestone and will include them next week in a PR. Putting in the milestone should be enough :) |
vnmabus
added a commit
to GAA-UAM/scikit-fda
that referenced
this pull request
May 14, 2020
Now the doctests work in versions where scikit-learn/scikit-learn#17205 is merged.
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 18, 2020
adrinjalali
pushed a commit
that referenced
this pull request
May 19, 2020
DavidGarciaFer
pushed a commit
to GAA-UAM/scikit-fda
that referenced
this pull request
Jun 21, 2020
Now the doctests work in versions where scikit-learn/scikit-learn#17205 is merged.
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17206
@thomasjpfan @adrinjalali @rth @jnothman