MNT Put back and properly deprecate MaskedArray#17199
Merged
rth merged 2 commits intoscikit-learn:masterfrom May 13, 2020
Merged
MNT Put back and properly deprecate MaskedArray#17199rth merged 2 commits intoscikit-learn:masterfrom
rth merged 2 commits intoscikit-learn:masterfrom
Conversation
rth
approved these changes
May 13, 2020
Member
rth
left a comment
There was a problem hiding this comment.
Thanks @NicolasHug !
There was no deprecation warning because as far as I know we don't maintain backward compatibility on the semi-private utils.fixes. We can certainty merge this, but we should also make it private in the near future.
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 18, 2020
adrinjalali
pushed a commit
that referenced
this pull request
May 19, 2020
Member
|
I don't think this fix worked as intended: https://app.circleci.com/pipelines/github/dabl/dabl/520/workflows/7d4714ee-68ca-4958-aca8-fd1b48f452ff/jobs/1199/steps |
Member
|
also reported here: scikit-optimize/scikit-optimize#902 (comment) |
Member
|
This is in fact because of this >5yr old FIXME: scikit-learn/sklearn/utils/deprecation.py Line 63 in ac6caa0 MaskedArray has a |
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17198
MaskedArray was deleted in #16725 without deprecation. It breaks scikit-optimize.
Sad, but I guess we need to put it back and deprecate...
CC @rth @thomasjpfan @adrinjalali
Should be in the bugfix release