Skip to content

ENH use colors from style in tree plotting#17187

Merged
jnothman merged 3 commits intoscikit-learn:masterfrom
amueller:plot_tree_styles
May 21, 2020
Merged

ENH use colors from style in tree plotting#17187
jnothman merged 3 commits intoscikit-learn:masterfrom
amueller:plot_tree_styles

Conversation

@amueller
Copy link
Copy Markdown
Member

@amueller amueller commented May 11, 2020 •
edited
Loading

fixes #16943 and some more of #13971.
This doesn't change the edge color for the bounding boxes, but it adjusts the background color of the boxes and the arrow colors.

import matplotlib.pyplot as plt
import seaborn as sns
from sklearn.datasets import load_iris
from sklearn import tree

clf = tree.DecisionTreeClassifier(random_state=0)
iris = load_iris()
clf = clf.fit(iris.data, iris.target)
tree.plot_tree(clf);

as before:
image

with plt.style.use('dark_background'):
before:
image

this pr:
image

with sns.set_style('whitegrid'):
before:
image

this pr:
image

with sns.set_style('dark'):
before:
image

this pr:
image

@amueller amueller force-pushed the plot_tree_styles branch from c8826fc to 94452f3 Compare May 11, 2020 20:16
@amueller
Copy link
Copy Markdown
Member Author

amueller commented May 11, 2020

I also did

for style in plt.style.available:
    with plt.style.context(style):
        plt.figure()
        tree.plot_tree(clf)

and all of them look reasonable. I didn't test all the seaborn styles but I think they should be fine.

No idea if this should be tested.
If this looks ok I can add a whatsnew.

@amueller amueller mentioned this pull request May 11, 2020
Closed
@cmarmo
Copy link
Copy Markdown
Contributor

cmarmo commented May 12, 2020

If this looks ok I can add a whatsnew.

For what it matters, this looks good to me. Thanks! :)

thomasjpfan
thomasjpfan approved these changes May 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a big enough fix to be added to the 0.24 whats new.

LGTM

@jnothman jnothman changed the title use colors from style in tree plotting ENH use colors from style in tree plotting May 21, 2020
@jnothman jnothman merged commit 2f26540 into scikit-learn:master May 21, 2020
@jnothman
Copy link
Copy Markdown
Member

jnothman commented May 21, 2020

Nice

@cmarmo cmarmo mentioned this pull request Jun 9, 2020
Closed
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@amueller @viclafargue
ENH use colors from style in tree plotting (scikit-learn#17187)
fb68f88
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@amueller @jayzed82
ENH use colors from style in tree plotting (scikit-learn#17187)
b07e5fe
@glemaitre glemaitre mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees

No one assigned

Labels

module:tree

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tree.plot_tree() does not visualize properly if also using seaborn.set_style()

4 participants

@amueller @cmarmo @jnothman @thomasjpfan