Skip to content

[MRG] Remove deprecated utils#17133

Merged
rth merged 7 commits intoscikit-learn:masterfrom
NicolasHug:remove_deprecated_utils
May 20, 2020
Merged

[MRG] Remove deprecated utils#17133
rth merged 7 commits intoscikit-learn:masterfrom
NicolasHug:remove_deprecated_utils

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

No description provided.

@NicolasHug NicolasHug changed the title [WIP] Remove deprecated utils [MRG] Remove deprecated utils May 6, 2020
@NicolasHug
Copy link
Copy Markdown
Member Author

@glemaitre @adrinjalali @thomasjpfan @rth @amueller @jnothman

Time for some cleaning!

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

def test_assert_less():
assert 0 < 1
with pytest.raises(AssertionError):
assert_less(1, 0)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy we don't have to test for this anymore :)

@rth rth merged commit 1931e14 into scikit-learn:master May 20, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants