Skip to content

DOC Amend plot_digits_classification.py to use notebook style#17016

Merged
glemaitre merged 6 commits intoscikit-learn:masterfrom
lucyleeow:plot_digits
May 20, 2020
Merged

DOC Amend plot_digits_classification.py to use notebook style#17016
glemaitre merged 6 commits intoscikit-learn:masterfrom
lucyleeow:plot_digits

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Amend plot_digits_classification.py to use notebook style with alternating code and text blocks. Also add some clarifications.

Any other comments?

@lucyleeow lucyleeow changed the title WIP Amend plot_digits_classification.py to use notebook style DOC Amend plot_digits_classification.py to use notebook style Apr 23, 2020
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments

_, axes = plt.subplots(1, 4, figsize=(10, 3))
images_and_predictions = list(zip(digits.images[n_samples // 2:], predicted))
for ax, (image, prediction) in zip(axes[1, :], images_and_predictions[:4]):
for ax, (image, prediction) in zip(axes, images_and_predictions[:4]):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@lucyleeow
Copy link
Copy Markdown
Member Author

Thanks @glemaitre, suggestions added

@glemaitre glemaitre merged commit 0deaa3b into scikit-learn:master May 20, 2020
@glemaitre
Copy link
Copy Markdown
Member

Thanks @lucyleeow

viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@lucyleeow lucyleeow deleted the plot_digits branch October 21, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants