Skip to content

DOC replace Boston in gradient_boosting.py#16891

Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
lucyleeow:DOC_gradboost
Apr 10, 2020
Merged

DOC replace Boston in gradient_boosting.py#16891
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
lucyleeow:DOC_gradboost

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

Towards #16155

Replace Boston dataset with Diabetes dataset in sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py

Also fixes typo in plot_iterative_imputer_variants_comparison.py.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @lucyleeow

)

# plot boston results
# plot california housing results
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the title.

For future reference, it is okay to open another PR for typos.

@thomasjpfan thomasjpfan changed the title [MRG] DOC replace Boston in gradient_boosting.py DOC replace Boston in gradient_boosting.py Apr 10, 2020
@thomasjpfan thomasjpfan merged commit 9a4bd37 into scikit-learn:master Apr 10, 2020
@lucyleeow lucyleeow deleted the DOC_gradboost branch April 15, 2020 15:13
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants